[Console] allow answer to be trimmed by adding a flag #32707
Conversation
|
I'm sorry, but this is a new feature which will be released in the next minor version, it cannot be backported, as per semver. |
|
I was "hoping" this could be considered a bug - the caller does not (and is not able to) get the full "real" answer back from the end-user, and this change provides an optional way for the caller to get the full answer, without breaking the behaviour of any existing calls. Anyway, I understand if it cannot be classed as a "bugfix". That means that this optional not-trimmed behaviour will not be possible to use until after 4.4 is released. |
|
Hmmm - I was fixing code for pre-PHP7 support, at least to see if I can make CI pass with the older PHP. |
According to #23210 (comment) we add a new flag in the Question class to be able to not trim the answer.
This is a "backport" request for #31626 - the code is completely backward-compatible, any existing use gets the answer trimmed. So this
setTrimmable(false)ability would only come into effect if someone modifies their code to use it.I am asking if it is OK/possible to implement this in the
3.4branch. I realise that this can be considered a "new feature" and so withsemverthe version should be bumped to3.5.0for a "new feature" that is backward-compatible. And I suspect that3.5is no longer allowed to happen. But maybe it could also be called a bug, because without this change there is no way to know that the user's answer has leading/trailing spaces.