Skip to content

Improve some URLs #32800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Improve some URLs #32800

merged 1 commit into from
Aug 8, 2019

Conversation

Arman-Hosseini
Copy link
Contributor

@Arman-Hosseini Arman-Hosseini commented Jul 29, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@nicolas-grekas
Copy link
Member

If we do this, we should do it for the whole codebase. There is no point in making it for some random files (except calling for an undefined amount of follow-ups, which we'd better not.)

@nicolas-grekas
Copy link
Member

@Arman-Hosseini up for screening the whole codebase? We could also improve links to bug reports, e.g. https://bugs.php.net/78175 instead of https://bugs.php.net/bug.php?id=78175

@Arman-Hosseini
Copy link
Contributor Author

Hi @nicolas-grekas .
I'm ready to do that.
Where to start?

@nicolas-grekas
Copy link
Member

grep "https*://" src/ + filter the result :)

@Arman-Hosseini
Copy link
Contributor Author

@nicolas-grekas .
Do I have to commit all the results on the branch of patch-10?

@nicolas-grekas
Copy link
Member

that would make sense, but do what's easiest for you of course

@Arman-Hosseini
Copy link
Contributor Author

I carefully review all the results and correct them as needed.

@nicolas-grekas
Copy link
Member

@Arman-Hosseini maybe you forget to push the result? We see no changes here :)

@Arman-Hosseini
Copy link
Contributor Author

@nicolas-grekas I am involved in a project and will be pushing it soon.

@Arman-Hosseini
Copy link
Contributor Author

Arman-Hosseini commented Aug 4, 2019

@nicolas-grekas Do the schema links in the xml files also need to be changed?

@nicolas-grekas
Copy link
Member

No need to patch xsd, this can have unwanted technical consequences.

@Arman-Hosseini
Copy link
Contributor Author

Arman-Hosseini commented Aug 4, 2019

@nicolas-grekas Can I change the long links that are redirected?
For example: http://support.microsoft.com/kb/323308 it's redirected to https://support.microsoft.com/en-us/help/323308/internet-explorer-file-downloads-over-ssl-do-not-work-with-the-cache-c

@Arman-Hosseini
Copy link
Contributor Author

Arman-Hosseini commented Aug 4, 2019

@nicolas-grekas Can I remove www from a link? Even for a link that is ultimately loaded with a www address?
For example: I use https://zend.com/ and finally it's redirected to https://www.zend.com/

Or even for a subdomain such as https://en.wikipedia.com/ and finally it's redirected to https://wikipedia.com/

@fabpot
Copy link
Member

fabpot commented Aug 5, 2019

@Arman-Hosseini I think using the shortest URL possible is always nice (even if the URL is redirected).

@nicolas-grekas
Copy link
Member

Thank you @Arman-Hosseini.

@nicolas-grekas nicolas-grekas merged commit fab17a4 into symfony:3.4 Aug 8, 2019
nicolas-grekas added a commit that referenced this pull request Aug 8, 2019
This PR was squashed before being merged into the 3.4 branch (closes #32800).

Discussion
----------

Improve some URLs

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

fab17a4 Improve some URLs
@Arman-Hosseini
Copy link
Contributor Author

@nicolas-grekas .
This process had not yet been completed.

@nicolas-grekas
Copy link
Member

I completed it :)
No need for more updates, that's really minor concern and we already have plenty of PRs.
Thanks!

@Arman-Hosseini Arman-Hosseini deleted the patch-10 branch September 7, 2019 19:37
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
This PR was squashed before being merged into the 3.4 branch (closes symfony#32800).

Discussion
----------

Improve some URLs

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

fab17a4 Improve some URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants