-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Improve some URLs #32800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve some URLs #32800
Conversation
If we do this, we should do it for the whole codebase. There is no point in making it for some random files (except calling for an undefined amount of follow-ups, which we'd better not.) |
@Arman-Hosseini up for screening the whole codebase? We could also improve links to bug reports, e.g. |
Hi @nicolas-grekas . |
|
@nicolas-grekas . |
that would make sense, but do what's easiest for you of course |
I carefully review all the results and correct them as needed. |
@Arman-Hosseini maybe you forget to push the result? We see no changes here :) |
@nicolas-grekas I am involved in a project and will be pushing it soon. |
@nicolas-grekas Do the schema links in the xml files also need to be changed? |
No need to patch xsd, this can have unwanted technical consequences. |
@nicolas-grekas Can I change the long links that are redirected? |
@nicolas-grekas Can I remove www from a link? Even for a link that is ultimately loaded with a www address? Or even for a subdomain such as |
@Arman-Hosseini I think using the shortest URL possible is always nice (even if the URL is redirected). |
Thank you @Arman-Hosseini. |
This PR was squashed before being merged into the 3.4 branch (closes #32800). Discussion ---------- Improve some URLs | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- fab17a4 Improve some URLs
@nicolas-grekas . |
I completed it :) |
This PR was squashed before being merged into the 3.4 branch (closes symfony#32800). Discussion ---------- Improve some URLs | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- fab17a4 Improve some URLs
Uh oh!
There was an error while loading. Please reload this page.