Skip to content

[Security\Http] Drop some useless param phpdoc annotations #32960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Aug 5, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

#32314 is removing some @param annotations in favor of scalar typehints, this removes the ones which were already useless on 3.4 (compound typehints).

@chalasr chalasr added this to the 3.4 milestone Aug 5, 2019
@chalasr chalasr force-pushed the sec-http-useless-params branch from 1ef838e to a4d72df Compare August 5, 2019 19:14
@fabpot
Copy link
Member

fabpot commented Aug 5, 2019

Let's do it on 4.4 instead, or not at all, I don't see the value of these changes TBH

@chalasr
Copy link
Member Author

chalasr commented Aug 5, 2019

Works for me

@chalasr chalasr closed this Aug 5, 2019
@chalasr chalasr deleted the sec-http-useless-params branch August 5, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants