Skip to content

[Security][Http] Add type-hints #32314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Security][Http] Add type-hints #32314

wants to merge 1 commit into from

Conversation

andreia
Copy link
Contributor

@andreia andreia commented Jul 2, 2019

Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR

This PR adds type-hints to the HTTP Security sub-component.

@derrabus
Copy link
Member

derrabus commented Jul 2, 2019

Please also check the failing unit tests. They are related to your changes.

@derrabus derrabus mentioned this pull request Jul 2, 2019
Closed
57 tasks
@chalasr chalasr added this to the 5.0 milestone Jul 2, 2019
linaori
linaori reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise everything looks fine, got a few remarks on docblocks and return types that could be improved upon, but shouldn't be blocking this PR in my opinion

@fabpot
Copy link
Member

fabpot commented Jul 27, 2019

@andreia Can you have a look at the remaining comment here? Thank you.

@andreia
Copy link
Contributor Author

andreia commented Aug 4, 2019

@fabpot Done

@fabpot fabpot mentioned this pull request Aug 5, 2019
Closed
@chalasr chalasr mentioned this pull request Aug 5, 2019
Closed
chalasr
chalasr approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed fabbot and removed some ? for args which have null as default value. Ready

@nicolas-grekas
Copy link
Member

Thank you @andreia.

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019
@nicolas-grekas
minor #32314 [Security][Http] Add type-hints (andreia)
86e1321 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Security][Http] Add type-hints

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        |

This PR adds type-hints to the HTTP Security sub-component.

Commits
-------

6bae9bc [Security][Http] Add type-hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@jderusse jderusse jderusse left review comments

@derrabus derrabus derrabus requested changes

@linaori linaori linaori left review comments

@chalasr chalasr chalasr approved these changes

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
9 participants
@andreia @derrabus @fabpot @nicolas-grekas @jderusse @Tobion @linaori @chalasr @carsonbot