"An instance of X" phpdocs removal #32973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22e3427 to
fb9bf39
Compare
fb9bf39 to
b45a526
Compare
|
fabbot errors are false positive. |
|
For 4.4 at least so that we reduce merge conflict? |
|
@nicolas-grekas I spent enough time on this. 5.0 is good enough for me. |
| * | ||
| * @return string An absolute URL | ||
| * | ||
| * @throws \LogicException | ||
| */ | ||
| public function generateUri($request, $path) | ||
| public function generateUri(Request $request, $path) |
There was a problem hiding this comment.
I ported the patch in this PR on 4.4 in #32974, but this file must be updated on master only, so it's not part of that other PR.
|
Closing for #32974 |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- "An instance of X" phpdocs removal | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - That's #32973 on 4.4 :P Commits ------- 7a44ed6 removed unneeded phpdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all phpdocs referring to instances of X
@param X $x A X instance(or similar).