[Intl] Excludes locale from language codes (split localized language names) #33148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerjeBr
suggested changes
Aug 13, 2019
|
if this is decided for 3.4, then 4.4 needs another PR to patch edit: actually no, we should do 4.4 (we qualified excluding codes a new feature before as well (https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Intl/CHANGELOG.md) |
|
@ro0NL Anything left in this PR before merging (a rebase is needed anyway)? |
|
done. |
fabpot
approved these changes
Sep 27, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2019
…lized language names) (ro0NL) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Excludes locale from language codes (split localized language names) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #33146 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> (includes #33140) Commits ------- 1a9f517 [Intl] Excludes locale from language codes (split localized language names)
|
Looks like this broke some tests, could you have a look @ro0NL please? |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 27, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form][Validator][Intl] Fix tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33148 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- e648a91 [Form][Validator][Intl] Fix tests
This was referenced Nov 12, 2019
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(includes #33140)