[Validator] Deprecated CacheInterface in favor of PSR-6 #33459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0398a4b to
f40dd36
Compare
8a59e7d to
6d09ea3
Compare
Tobion
approved these changes
Sep 4, 2019
7e0a2b3 to
4657cff
Compare
All right, I've inlined |
src/Symfony/Bundle/FrameworkBundle/Resources/config/validator.xml
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Mapping/Cache/CacheInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Mapping/Factory/LazyLoadingMetadataFactory.php
Outdated
Show resolved
Hide resolved
fancyweb
reviewed
Sep 4, 2019
src/Symfony/Component/Validator/Mapping/Cache/DoctrineCache.php
Outdated
Show resolved
Hide resolved
fbadf44 to
8a200c0
Compare
src/Symfony/Component/Validator/Mapping/Factory/LazyLoadingMetadataFactory.php
Outdated
Show resolved
Hide resolved
8a200c0 to
bfe8ccc
Compare
nicolas-grekas
approved these changes
Sep 5, 2019
bfe8ccc to
b335ffb
Compare
b335ffb to
0b08040
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 5, 2019
…6 (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Deprecated CacheInterface in favor of PSR-6 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #33414 | License | MIT | Doc PR | TODO With PSR-6, the validator component does not need its own `CacheInterface`, so let's remove it. Note that I still use the now deprecated `Psr6Cache` class to keep the logic inside `LazyLoadingMetadataFactory` simple. My plan would be to inline all logic from `Psr6Cache` into `LazyLoadingMetadataFactory` for 5.0. Commits ------- 0b08040 [Validator] Deprecated CacheInterface in favor of PSR-6.
nicolas-grekas
added a commit
that referenced
this pull request
Sep 5, 2019
…rrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] Removed CacheInterface in favor of PSR-6 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33414 | License | MIT | Doc PR | symfony/symfony-docs#12276 This PR removes the deprecation layer of #33459. Commits ------- 34b141c [Validator] Removed CacheInterface in favor of PSR-6.
nicolas-grekas
added a commit
that referenced
this pull request
Sep 5, 2019
…errabus) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Update "suggest" section in composer.json | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A After #33459, the composer suggestions for the validator component are a bit misleading. Sorry for having missed that in my PR. Commits ------- 5bf8cca [Validator] Update "suggest" section in composer.json.
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Document the validator's switch to PSR-6 This PR documents symfony/symfony#33459 and fixes #12275. Commits ------- 2f010b7 Document the validator's switch to PSR-6.
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PSR-6, the validator component does not need its own
CacheInterface, so let's remove it.Note that I still use the now deprecatedPsr6Cacheclass to keep the logic insideLazyLoadingMetadataFactorysimple. My plan would be to inline all logic fromPsr6CacheintoLazyLoadingMetadataFactoryfor 5.0.