Document the validator's switch to PSR-6 #12276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2019
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 5, 2019
…rrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] Removed CacheInterface in favor of PSR-6 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33414 | License | MIT | Doc PR | symfony/symfony-docs#12276 This PR removes the deprecation layer of #33459. Commits ------- 34b141c [Validator] Removed CacheInterface in favor of PSR-6.
|
Hi 👋 and thanks for your PR. |
737b62a to
2f010b7
Compare
|
Thank you for your review, @OskarStark. I've added that directive, but I'm a bit unsure about the wording. Should I somehow mention the old behavior as well or do we expect users to look this up in the older branch of the documentation should they need it? |
xabbuh
approved these changes
Sep 5, 2019
|
We could, but to me it’s ok to just mention the “as is”/“current recommendation” 👍🏻🤞🏻 Thanks |
OskarStark
approved these changes
Sep 5, 2019
|
Thank you Alexander! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Document the validator's switch to PSR-6 This PR documents symfony/symfony#33459 and fixes #12275. Commits ------- 2f010b7 Document the validator's switch to PSR-6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents symfony/symfony#33459 and fixes #12275.