[WebProfiler] Deprecated intercept_redirects in 4.4 #33507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Sep 9, 2019
src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Sep 9, 2019
src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Sep 9, 2019
stof
requested changes
Sep 9, 2019
src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/ConfigurationTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php
Show resolved
Hide resolved
|
@stof I have split the tests. Can you please review? |
fabpot
approved these changes
Sep 16, 2019
|
Thank you @dorumd. |
|
@dorumd Can you submit a PR on master (I've just merged 4.4 into master) to remove support for the deprecated code? |
fabpot
pushed a commit
to lyrixx/symfony
that referenced
this pull request
Sep 23, 2019
…irects in 4.4 (dorumd)\"
fabpot
added a commit
that referenced
this pull request
Sep 23, 2019
…ept_redirects in 4.4 (dorumd)" (lyrixx) This PR was squashed before being merged into the 4.4 branch (closes #33621). Discussion ---------- Revert "feature #33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)" This reverts commit 21a05de, reversing changes made to 24faadc. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | | Tickets | Fix #33467 | License | MIT | Doc PR | Commits ------- e767bb1 Revert \"feature #33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)\"
nicolas-grekas
added a commit
that referenced
this pull request
Sep 24, 2019
* 4.4: [Security/Http] fix typo in deprecation message [Security] Deprecate isGranted()/decide() on more than one attribute Fixed a minor typo in the UPGRADE to 5.0 guide Various tweaks 3.4 Various tweaks 4.3 [Security] Make stateful firewalls turn responses private only when needed [PhpUnit] Fix usleep mock return value Revert \"feature #33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)\" [TwigBundle] typo [TwigBundle] fix test case [Lock] use Predis\ClientInterface instead of Predis\Client Allow Twig 3 Minor tweaks Fix version typo in deprecation notice [Form][SubmitType] Add "validate" option hint to the --parse-tags when parsing tags fails Make legacy "wrong" RFC2047 encoding apply only to one header
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated
web_profiler.intercept_redirectsconfig option in symfony 4.4.