Keeping backward compatibility with legacy FlattenException usage #33941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Oct 9, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Tickets | Fix #33929 |
| License | MIT |
| Doc PR | - |
yceruto
commented
Oct 9, 2019
| @@ -37,6 +39,11 @@ class FlattenException | |||
| private $file; | |||
| private $line; | |||
|
|
|||
| public static function create(\Exception $exception, int $statusCode = null, array $headers = []): self | |||
There was a problem hiding this comment.
Restoring for a smooth migration, it can be deprecated in 5.1.
yceruto
commented
Oct 9, 2019
| @@ -33,6 +33,7 @@ | |||
| }, | |||
| "autoload": { | |||
| "psr-4": { "Symfony\\Component\\ErrorRenderer\\": "" }, | |||
| "classmap": [ "Resources/stubs/Exception/FlattenException.php" ], | |||
There was a problem hiding this comment.
this would fix the compiler error mentioned here #33929 (comment)
82a9e46 to
042575d
Compare
8c4cda4 to
928363c
Compare
fabpot
approved these changes
Oct 11, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 11, 2019
…ption usage (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- Keeping backward compatibility with legacy FlattenException usage | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | Fix #33929 | License | MIT | Doc PR | - Commits ------- 928363c Keeping backward compatibility with legacy FlattenException usage
|
ugly quickfix. put to |
This was referenced Nov 12, 2019
Merged
Merged
fnagel
added a commit
to fnagel/JMSJobQueueBundle
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.