[ErrorRenderer] extend legacy exception for backwards compatibility #33981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 14, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
83450a3 to
6c1e244
Compare
nicolas-grekas
approved these changes
Oct 14, 2019
yceruto
requested changes
Oct 14, 2019
| @@ -39,12 +40,12 @@ class FlattenException | |||
| private $file; | |||
| private $line; | |||
|
|
|||
| public static function create(\Exception $exception, int $statusCode = null, array $headers = []): self | |||
| public static function create(\Exception $exception, $statusCode = null, array $headers = []): self | |||
|
Just asking: Did you find another BC break? Won't #33941 be enough to keep the BC? |
see 3.4 and 4.3 in https://travis-ci.org/symfony/symfony/builds |
94c0a72 to
7432e68
Compare
|
Status: Needs Review |
7432e68 to
71a0b9b
Compare
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 15, 2019
…atibility (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorRenderer] extend legacy exception for backwards compatibility | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 71a0b9b extend legacy exception for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.