[HttpClient] resolve promise chains on HttplugClient::wait() #33944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bac85ce to
670aed4
Compare
|
I figured out the issue: calling PR ready \o/ |
670aed4 to
af16c62
Compare
|
For the record, the following script runs in 5s: <?php
require 'vendor/autoload.php';
use Symfony\Component\HttpClient\HttplugClient;
$client = new HttplugClient();
$s = microtime(1);
$client->sendAsyncRequest($client->createRequest('GET', 'https://localhost:8000/?sleep=4'));
$client->sendAsyncRequest($client->createRequest('GET', 'https://localhost:8000/?sleep=2'))
->then(function ($resp) use ($client) {
return $client->sendAsyncRequest($client->createRequest('GET', 'https://localhost:8000/?sleep=3'));
});
$client->wait();
dump(microtime(1) - $s); |
af16c62 to
45e9cac
Compare
45e9cac to
ea0be07
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 12, 2019
…() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] resolve promise chains on HttplugClient::wait() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #32142 | License | MIT | Doc PR | - Follow up of #33743 Right now, keeping a reference to promise objects returned by `HttplugClient::sendAsyncRequest()`, then calling their `wait()` method is the only way to actually resolve the promises. That's why when these promises are destructed, we cancel the corresponding HTTP request. But thanks to the `HttplugClient::wait()` method, we have a hook to tick the event loop managed by the Symfony client. I added a test case to run into this situation. ~It fails currently. I'd like asking @joelwurtz, @dbu and/or maybe @Nyholm if you could have a look and finish this PR? I'm not that familiar with promises and you might get faster and better to the goal. Anyone else is welcome also of course. Thank you for having a look :) PR welcome on my fork or as a separate one on this repos.~ Commits ------- ea0be07 [HttpClient] resolve promise chains on HttplugClient::wait()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #33743
Right now, keeping a reference to promise objects returned by
HttplugClient::sendAsyncRequest(), then calling theirwait()method is the only way to actually resolve the promises. That's why when these promises are destructed, we cancel the corresponding HTTP request.But thanks to the
HttplugClient::wait()method, we have a hook to tick the event loop managed by the Symfony client.I added a test case to run into this situation.
It fails currently. I'd like asking @joelwurtz, @dbu and/or maybe @Nyholm if you could have a look and finish this PR? I'm not that familiar with promises and you might get faster and better to the goal. Anyone else is welcome also of course. Thank you for having a look :) PR welcome on my fork or as a separate one on this repos.