[HttpClient] Async HTTPlug client #33743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Sep 27, 2019
addfa6f to
668e09b
Compare
89312ca to
f5e1496
Compare
Nyholm
commented
Sep 28, 2019
f647abe to
02d7aac
Compare
5e63313 to
0cbe120
Compare
nicolas-grekas
previously approved these changes
Oct 3, 2019
There was a problem hiding this comment.
As discussed on Slack, I rewrote the promise part: the previous logic was copied from https://github.com/php-http/curl-client/blob/master/src/PromiseCore.php yet the logic there is completely broken (see php-http/curl-client#59 and unlike guzzle6-adapter which uses Guzzle promises and thus works as expected.)
The new HttplugPromise implements the correct logic (hopefuly ;) ), has a cancel() method and is compatible with Guzzle promises.
Nyholm
commented
Oct 3, 2019
1444872 to
067ffcd
Compare
stof
requested changes
Oct 4, 2019
31449b9 to
2d3a241
Compare
This was referenced Oct 4, 2019
nicolas-grekas
approved these changes
Oct 4, 2019
|
I pushed two small bugfixes. Im happy with this PR now |
9f6f7c6 to
4fd593f
Compare
|
Thank you @Nyholm. |
stof
reviewed
Oct 7, 2019
|
|
||
| public function cancel(): void | ||
| { | ||
| $this->promise->cancel(); |
There was a problem hiding this comment.
shouldn't this also call the cancel callback ?
There was a problem hiding this comment.
the guzzle promise will call it already
nicolas-grekas
added a commit
that referenced
this pull request
Oct 12, 2019
…() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] resolve promise chains on HttplugClient::wait() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #32142 | License | MIT | Doc PR | - Follow up of #33743 Right now, keeping a reference to promise objects returned by `HttplugClient::sendAsyncRequest()`, then calling their `wait()` method is the only way to actually resolve the promises. That's why when these promises are destructed, we cancel the corresponding HTTP request. But thanks to the `HttplugClient::wait()` method, we have a hook to tick the event loop managed by the Symfony client. I added a test case to run into this situation. ~It fails currently. I'd like asking @joelwurtz, @dbu and/or maybe @Nyholm if you could have a look and finish this PR? I'm not that familiar with promises and you might get faster and better to the goal. Anyone else is welcome also of course. Thank you for having a look :) PR welcome on my fork or as a separate one on this repos.~ Commits ------- ea0be07 [HttpClient] resolve promise chains on HttplugClient::wait()
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 1, 2019
…holm, nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Adapted the HTTPlug integration docs to Async Client This should be merged with symfony/symfony#33743 Closes #12472 Closes #12475 Commits ------- d353b61 Complete doc for 4.4 features 7295404 Adapted the HTTPlug integration docs to Async Client
This was referenced Nov 12, 2019
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Nov 19, 2019
…ntation (Taluu) This PR was merged into the 4.4 branch. Discussion ---------- States that the HttpClient provides a Http Async implementation | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no (not really) | New feature? | no (not really) | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Add in the composer.json of the HttpClient that it now provides an implementation for the `php-http/async-client-implementation` virtual package, as @Nyholm did the implementation on the HttpPlug bridge in #33743. Commits ------- 8a460ce States that the HttpClient provides a Http Async implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
HttplugClient's dependency onPsr18Client. It will also add anHttplugPromiseto make sure we sure we respect the Httplug'sHttpAsyncClientinterface.It implements
HttpAsyncClient::sendAsyncRequest()and provides two extensions:HttplugPromise::cancel()allows cancelling a promise (and the underlying response)HttplugClient::wait()allows to tick the promise pool, with configurable timeouts.