Skip to content

[TwigBridge] Add show-deprecations option to the lint:twig command #33961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Oct 11, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #33957 (partially)
License MIT
Doc PR TODO

lint-twig-deprecations

@yceruto yceruto force-pushed the lint-twig-deprecations branch from 87dfedb to a676c7e Compare October 14, 2019 12:45
@yceruto
Copy link
Member Author

yceruto commented Oct 14, 2019

@chalasr comments addressed. Thanks!

@fabpot
Copy link
Member

fabpot commented Oct 14, 2019

Thank you @yceruto.

fabpot added a commit that referenced this pull request Oct 14, 2019
…twig command (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Add show-deprecations option to the lint:twig command

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #33957 (partially)
| License       | MIT
| Doc PR        | TODO

![lint-twig-deprecations](https://user-images.githubusercontent.com/2028198/66682028-fe994e00-ec41-11e9-91f3-43885c9ee48b.png)

Commits
-------

a676c7e Add show-deprecations option to lint:twig command
@fabpot fabpot merged commit a676c7e into symfony:4.4 Oct 14, 2019
@yceruto yceruto deleted the lint-twig-deprecations branch October 14, 2019 19:54
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally fail for deprecations in our various lint commands
5 participants