[Monolog] Use a standalone http client for ElasticsearchLogstashHandler #34423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mean the logger will not be injected in this Handler, and it will prevent an infinite loop : a log > ElasticsearchLogstashHandler > fire an HTTP request > the http request emits another log > ...
2e400b5 to
6fc6263
Compare
|
I really think this should be on monolog-bundle. I don't think any of the objections are real blockers. |
| @@ -446,6 +448,11 @@ public function load(array $configs, ContainerBuilder $container) | |||
| $container->registerForAutoconfiguration(LoggerAwareInterface::class) | |||
| ->addMethodCall('setLogger', [new Reference('logger')]); | |||
|
|
|||
| $handlerAutoconfiguration = $container->registerForAutoconfiguration(ElasticsearchLogstashHandler::class); | |||
There was a problem hiding this comment.
I would bind on HandlerInterface instead - all handlers that need an http_client cannot use the default one since it logs.
May I ask why? What's the issue with putting the code here? |
4.4 is closed for new feats, and what is configured here is the responsibility of the monolog-bundle :) |
|
This is not a feature, it's a bug fix :) |
|
Closing in favor of symfony/monolog-bundle#331 |
lyrixx
added a commit
to symfony/monolog-bundle
that referenced
this pull request
Jan 6, 2020
This PR was merged into the 3.x-dev branch. Discussion ---------- Use an HttpClient without logger in all handlers fixes: * symfony/symfony#34423 * symfony/symfony#32360 (comment) * symfony/symfony-docs#12642 Commits ------- faf6943 Use an HttpClient without logger in all handlers
dani-danigm
pushed a commit
to dani-danigm/monolog-bundle
that referenced
this pull request
Jun 15, 2022
This PR was merged into the 3.x-dev branch. Discussion ---------- Use an HttpClient without logger in all handlers fixes: * symfony/symfony#34423 * symfony/symfony#32360 (comment) * symfony/symfony-docs#12642 Commits ------- 2abc6f6 Use an HttpClient without logger in all handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mean the logger will not be injected in this Handler, and it will
prevent an infinite loop :
a log > ElasticsearchLogstashHandler > fire an HTTP request > the http
request emits another log > ...
I did not submit this patch on monolog-bundle because: