[Monolog] Do not autowire the ElasticsearchLogstashHandler service #12642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If so, Symfony will inject an HttpClient, and this one has a logger in it. So for each log, another log for the HTTP Client will be emitted => infinite loop => 💥
|
Instead of this, I would suggest to let monolog-bundle do the same as in |
This was referenced Nov 17, 2019
Closed
|
Let's close this "temporary fix" in favor of a more permanent solution proposed in symfony/monolog-bundle#331. Thanks. |
lyrixx
added a commit
to symfony/monolog-bundle
that referenced
this pull request
Jan 6, 2020
This PR was merged into the 3.x-dev branch. Discussion ---------- Use an HttpClient without logger in all handlers fixes: * symfony/symfony#34423 * symfony/symfony#32360 (comment) * symfony/symfony-docs#12642 Commits ------- faf6943 Use an HttpClient without logger in all handlers
dani-danigm
pushed a commit
to dani-danigm/monolog-bundle
that referenced
this pull request
Jun 15, 2022
This PR was merged into the 3.x-dev branch. Discussion ---------- Use an HttpClient without logger in all handlers fixes: * symfony/symfony#34423 * symfony/symfony#32360 (comment) * symfony/symfony-docs#12642 Commits ------- 2abc6f6 Use an HttpClient without logger in all handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If so, Symfony will inject an HttpClient, and this one has a logger in it. So for each log, another log for the HTTP Client will be emitted => infinite loop => 💥
ref: symfony/symfony#32360 (comment)