[DependencyInjection] definitions are valid objects #34515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 22, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34480 |
| License | MIT |
| Doc PR |
ogizanagi
approved these changes
Nov 25, 2019
fabpot
approved these changes
Nov 25, 2019
|
I'm wondering if this should not be deprecated in 5.1. WDYT? |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 25, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] definitions are valid objects | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34480 | License | MIT | Doc PR | Commits ------- 0acaa5c definitions are valid objects
|
Deprecating what? This pass is new to 4.4 :) |
|
Deprecating the possibility to pass a definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.