[DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag #34732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should target this on branch 4.4 |
|
Fixed. Thank @maxhelias |
nicolas-grekas
approved these changes
Nov 30, 2019
maxhelias
approved these changes
Nov 30, 2019
fabpot
approved these changes
Nov 30, 2019
|
Thank you @tienvx. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2019
…allowed in 'bind' tag (tienvx) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs/pull/12741 <!-- required for new features --> Add test case for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowed Commits ------- e38f7d4 [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 2, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Bind tagged services Update documentation for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services NOTE: this documentation require symfony/symfony#34732 to be merged Commits ------- 7ec6d9d [DependencyInjection] Bind tagged services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowed