Add COMPOSER_BIN environment variable for PHPUnit Bridge #35166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there might be a better way, based on |
|
I'm not sure it works. When I run that command on Scrutinizer I get: But when I run |
|
Replaced by #35219, which should solve the issue also. Thank you @NoodlesNZ! |
|
Thanks @nicolas-grekas, a much more eloquent solution. I tested the patch on Scrutinizer and it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a weird edge case when PHPUnit Bridge tries to get the composer binary path inside Scrutinizer CI (see attached ticket). To work around this edge case I added an environment variable for the composer binary path.