[PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script #35219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of #35166 (comment)? |
|
@nicolas-grekas while About COMPOSER_BIN from #35166 |
be6469b to
0e1c843
Compare
nicolas-grekas
approved these changes
Jan 7, 2020
…executable is wrapped into a bash script
6b2bf5c to
25c805e
Compare
|
Thank you @oleg-andreyev. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 7, 2020
…, composer executable is wrapped into a bash script (oleg-andreyev) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34796 | License | MIT | Doc PR | - Locally using [phpenv](https://github.com/phpenv/phpenv) together [phpenv-composer](https://github.com/ngyuki/phpenv-composer) with for managing php versions and composer installations. `which composer` is detecting wrapper instead of binary. Before appending PHP executable to composer path need to validate that detected composer is not a wrapper otherwise PHP will simply return the content of a wrapper Commits ------- 25c805e [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally using phpenv together phpenv-composer with for managing php versions and composer installations.
which composeris detecting wrapper instead of binary.Before appending PHP executable to composer path need to validate that detected composer is not a wrapper otherwise PHP will simply return the content of a wrapper