[DomCrawler] Rename UriExpander.php -> UriResolver #35667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Feb 10, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | refs symfony/symfony-docs#13054 (comment) |
| License | MIT |
| Doc PR | symfony/symfony-docs#13054 // don't open a new issue in doc repo |
ba30cb1 to
a52736b
Compare
ro0NL
reviewed
Feb 10, 2020
| @@ -5,7 +5,7 @@ CHANGELOG | |||
| ----- | |||
|
|
|||
| * Added an internal cache layer on top of the CssSelectorConverter | |||
| * Added `UriExpander` to expand an URL according to another URL | |||
| * Added `UriResolved` to resolve an URI according to a base URI | |||
OskarStark
reviewed
Feb 10, 2020
| { | ||
| /** | ||
| * Expand an URI according to a current Uri. | ||
| * Resolve an URI according to a base URI. |
fabpot
approved these changes
Feb 11, 2020
a52736b to
3217f81
Compare
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2020
…rixx) This PR was merged into the 5.1-dev branch. Discussion ---------- [DomCrawler] Rename UriExpander.php -> UriResolver | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | refs symfony/symfony-docs#13054 (comment) | License | MIT | Doc PR | symfony/symfony-docs#13054 // don't open a new issue in doc repo Commits ------- 3217f81 [DomCrawler] Rename UriExpander.php -> UriResolver
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.