Skip to content

[Notifier] Add Zulip notifier bridge #36616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

[Notifier] Add Zulip notifier bridge #36616

merged 1 commit into from
Aug 6, 2020

Conversation

phpfour
Copy link
Contributor

@phpfour phpfour commented Apr 28, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets See #33687
License MIT
Doc PR symfony/symfony-docs#13604

This adds a Zulip (another popular open source Slack alternative) transport for the new Notifier component.

Sample DSN

ZULIP_DSN=zulip://test-bot@zulipchat.com:api-key@example.zulipchat.com?channel=builds

Configuration

# config/packages/notifier.yaml
framework:
    notifier:
        chatter_transports:
            zulip: '%env(ZULIP_DSN)%'

Example

public function index(ChatterInterface $chatter)
{
    $message = (new ChatMessage('New order arrived!', new ZulipOptions('Ordering')))
        ->transport('zulip');

    $chatter->send($message);

    ...
}

@phpfour phpfour force-pushed the feature-notifier-zulip branch from b9f9970 to 9780b3d Compare April 28, 2020 21:12
javiereguiluz
javiereguiluz approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phpfour Thanks for this contribution!

@phpfour phpfour mentioned this pull request Apr 30, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone May 1, 2020
noniagriconomie
noniagriconomie reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition :)

@phpfour phpfour force-pushed the feature-notifier-zulip branch from 6d11550 to 2e59bd6 Compare July 4, 2020 14:23
@phpfour
Copy link
Contributor Author

phpfour commented Jul 4, 2020

Thanks for the notes @noniagriconomie, the PR has been updated for 5.2 👍🏻

@fabpot fabpot force-pushed the feature-notifier-zulip branch from 2e59bd6 to bd4fd32 Compare August 6, 2020 06:16
@fabpot
Copy link
Member

fabpot commented Aug 6, 2020

Thank you @phpfour.

@fabpot fabpot merged commit 558dfa8 into symfony:master Aug 6, 2020
@fabpot
Copy link
Member

fabpot commented Aug 10, 2020

@phpfour Can you submit a PR on symfony/recipes (you can have a look at other notifier bridge recipes to get some inspiration)?

@phpfour phpfour mentioned this pull request Aug 12, 2020
Merged
@phpfour
Copy link
Contributor Author

phpfour commented Aug 12, 2020

@fabpot Just added the recipe, thanks!

xabbuh added a commit to symfony/symfony-docs that referenced this pull request Aug 21, 2020
@xabbuh
minor #13604 [Notifier] Add Zulip entry (phpfour)
e52e2a4 
This PR was squashed before being merged into the master branch.

Discussion
----------

[Notifier] Add Zulip entry

Added entry for this feature: symfony/symfony#36616

I have question, the integration supports sending notification directly to a person through the recipient parameter. Should that be documented somewhere?

Commits
-------

2fdc9ca [Notifier] Add Zulip entry
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@noniagriconomie noniagriconomie noniagriconomie left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@phpfour @fabpot @javiereguiluz @noniagriconomie @nicolas-grekas @carsonbot