Skip to content

[Notifier] Add Zulip entry #13604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

[Notifier] Add Zulip entry #13604

merged 1 commit into from
Aug 21, 2020

Conversation

phpfour
Copy link
Contributor

@phpfour phpfour commented Apr 30, 2020

Added entry for this feature: symfony/symfony#36616

I have question, the integration supports sending notification directly to a person through the recipient parameter. Should that be documented somewhere?

@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Apr 30, 2020
@phpfour phpfour force-pushed the notifier-zulip branch 4 times, most recently from 78665af to b1dd031 Compare July 6, 2020 10:10
fabpot added a commit to symfony/symfony that referenced this pull request Aug 6, 2020
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Notifier] Add Zulip notifier bridge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | See #33687
| License       | MIT
| Doc PR        | symfony/symfony-docs#13604

This adds a [Zulip](https://zulipchat.com/) (another popular open source Slack alternative) transport for the new Notifier component.

#### Sample DSN

```ZULIP_DSN=zulip://test-bot@zulipchat.com:api-key@example.zulipchat.com?channel=builds```

#### Configuration

```yml
# config/packages/notifier.yaml
framework:
    notifier:
        chatter_transports:
            zulip: '%env(ZULIP_DSN)%'
```

#### Example

```php
public function index(ChatterInterface $chatter)
{
    $message = (new ChatMessage('New order arrived!', new ZulipOptions('Ordering')))
        ->transport('zulip');

    $chatter->send($message);

    ...
}
```

Commits
-------

bd4fd32 Adds Zulip notifier bridge
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Aug 8, 2020
@xabbuh xabbuh added this to the 5.2 milestone Aug 21, 2020
@xabbuh
Copy link
Member

xabbuh commented Aug 21, 2020

Thank you @phpfour.

@xabbuh xabbuh merged commit e52e2a4 into symfony:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants