Move from Travis to Github Actions #36649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look much different from my approach, especially since I moved to setup-php approach after the suggestion from @COil. Note that currently we don't want to move all the tests, but only those requiring additional docker services. |
|
I propose to merge #36647 first, then evaluate if we'd benefit from the extra steps proposed here. Right now, Travis is serving us well so I don't feel the need to move away from it. |
|
I've been doing some work on this issue, if you need some help. |
|
ok, now it does @jakzal. That's nice. If this PR gave some ideas that's already something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft answering today's Twitter call of @nicolas-grekas on this issue: #36427
I also saw @jakzal's PR of #36647 but I decided to restart from scratch as I have played a bit on GH Actions on a few projects and I propose a different approach.
Visible here: https://github.com/plopix/symfony/actions
This PR brings:
I think the move should be complete from Travis to GH Actions (if Symfony wants that move)
And that means moving all the Travis concept to Github Actions, which ultimately means rewriting the
travis.ymlThe current logic is "HUGE" I did not get all the reasons of everything yet, but I am willing to contribute here, so I will ask questions here or on Slack, if you think that's cool.
@jakzal we can also progress on that together if you are up to it. (on this PR or yours if for any reasons what I bring here is not "good")
TODOs:
Regarding the
depsand the matrix, I wonder if we should have 3 different jobs. The bad part of this is that we cannot reuse steps... and that would mean duplicating too much I guess.Let me know