Skip to content

Conversation

Plopix
Copy link
Contributor

@Plopix Plopix commented May 1, 2020

This is the first draft answering today's Twitter call of @nicolas-grekas on this issue: #36427

I also saw @jakzal's PR of #36647 but I decided to restart from scratch as I have played a bit on GH Actions on a few projects and I propose a different approach.

Visible here: https://github.com/plopix/symfony/actions

This PR brings:

  • shivammathur/setup-php to simplify PHP setup and extension
  • caches
  • a first draft of running the tests
  • parallel
  • move the env vars globally
  • grouping of output when using parallel
  • few service configurations

I think the move should be complete from Travis to GH Actions (if Symfony wants that move)
And that means moving all the Travis concept to Github Actions, which ultimately means rewriting the travis.yml

The current logic is "HUGE" I did not get all the reasons of everything yet, but I am willing to contribute here, so I will ask questions here or on Slack, if you think that's cool.

@jakzal we can also progress on that together if you are up to it. (on this PR or yours if for any reasons what I bring here is not "good")

TODOs:

  • kafka
  • deps low, high logic
  • vulcain
  • ldap
  • running the couchebase command on the service (never did that yet)
  • decide the Docker images to use
  • sigchild-enabled PHP and Process component
  • SYMFONY_PHPUNIT_BRIDGE_PR thing
  • .github/build-packages.php
  • and more...

Regarding the deps and the matrix, I wonder if we should have 3 different jobs. The bad part of this is that we cannot reuse steps... and that would mean duplicating too much I guess.

Let me know

@jakzal
Copy link
Contributor

jakzal commented May 1, 2020

It doesn't look much different from my approach, especially since I moved to setup-php approach after the suggestion from @COil.

Note that currently we don't want to move all the tests, but only those requiring additional docker services.

@nicolas-grekas
Copy link
Member

I propose to merge #36647 first, then evaluate if we'd benefit from the extra steps proposed here. Right now, Travis is serving us well so I don't feel the need to move away from it.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 1, 2020
@fr4ngus
Copy link

fr4ngus commented May 2, 2020

I've been doing some work on this issue, if you need some help.

@Plopix
Copy link
Contributor Author

Plopix commented May 2, 2020

ok, now it does @jakzal. That's nice.
@nicolas-grekas you're the boss, so as you wish

If this PR gave some ideas that's already something!

@nicolas-grekas
Copy link
Member

Thank you for the proposal @Plopix, let's close for now and see how things go with #36647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants