[HttpClient] add TimeoutExceptionInterface #36766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab5e322 to
366540f
Compare
nicolas-grekas
commented
May 8, 2020
| @@ -23,7 +23,7 @@ | |||
| "require": { | |||
| "php": "^7.2.5", | |||
| "psr/log": "^1.0", | |||
| "symfony/http-client-contracts": "^1.1.8|^2", | |||
| "symfony/http-client-contracts": "^2.1.1", | |||
There was a problem hiding this comment.
tag to be added on symfony/contracts and symfony/http-client-contracts after merge
366540f to
d20a0c3
Compare
javiereguiluz
approved these changes
May 9, 2020
e7a45e8 to
ab236d6
Compare
ostrolucky
reviewed
May 9, 2020
d80448b to
e89a845
Compare
e89a845 to
bc79222
Compare
bc79222 to
ab8eca0
Compare
fabpot
approved these changes
May 10, 2020
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a design issue: unlike any other
TransportExceptionInterface, timeouts are not fatal transport errors. For this reason, we must allow one to identify them.This PR also marks exception classes asthis would revert #30549@internal, to encourage ppl to catch them using their interface and not their class name.