[DomCrawler] Catch expected ValueError #36906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4eb13be to
b1db137
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler] Catch expected ValueError | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A This is #36906 ported to the 4.4 branch. Commits ------- 32691e5 [DomCrawler] Catch expected ValueError.
This was referenced May 26, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mb_convert_encoding()raises aValueErroron php 8 if an unknown character set is passed. This causes trouble with the whole test suite because the temporary error handler is not deregistered in that case.Since the previously raised warning was actively ignored by that error handler, I'm now ignoring the
ValueErroras well. Also, I've wrapped therestore_error_handler()call into afinallystatement to make the whole construct a bit more robust.