[PropertyAccess] Fix getter call order BC #37053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 2, 2020
|
@dunglas thanks for the review. Actually I’m not 100% sure if this fix is good enough and will not break other things in Property Info. What do you think? How should I handle the breaking tests, leave as is now because it will be green after merge or I should split the PR? |
|
Please bump That should fix deps=low tests. deps=high ones will be fixed once the patch is merged up. |
968ce89 to
8cf8068
Compare
|
Thank you @1ed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property Accessor breaks BC due to a change in the order of calling the getters, see #37052