Provides a way to override cache and log folders from the ENV #37114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why limiting this feature to the MicroKernelTrait and not having it in the base Kernel class? It might be confusing. |
|
very good question @GromNaN I think the Kernel is to be really generic where the Trait is more related to Flex and Symfony a Framework (vs as a Component) So I will let you guys decide, but I vote for the Trait ;-) |
yceruto
approved these changes
Jun 9, 2020
nicolas-grekas
approved these changes
Jun 9, 2020
fabpot
approved these changes
Jun 9, 2020
|
Thank you @Plopix. |
|
Not an issue, but I thought the default value was already very opinionated. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 13, 2020
…e ENV (Plopix) This PR was merged into the master branch. Discussion ---------- Provides a way to override cache and log folders from the ENV Related to this new feature symfony/symfony#37114. But I wonder if we have not oversimplified this PR: symfony/symfony#37114 Actually doing the documentation #13787 I figured that with #37114 we removed the important split per `env`. In development mode (docker or not) we could definitely have the same project working in N Symfony different environments and this new `APP_CACHE_DIR` will only set the same path for all environments. That would be manageable in the Virtualhost but in CLI that would be a pain to manage. Also, we could rely on the DotEnv mechanism, but that could be really easy to forget. I wonder if we should not change the code to: symfony/symfony#37232 Depending on the decisions I will update the doc here. Commits ------- 88b081c Provides a way to override cache and log folders from the ENV
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Docker and especially on Mac OS X, performances are terrible when using a "mount" on the host inside the container. (which happens by default)
To optimize the performances, one of the tricks is to change where the application is going to write the cache and the logs.
This PR provides a new env variables
APP_CACHE_DIRandAPP_LOG_DIRwhich can be set to change where will be saved the caches and the logs.I know we can do it per project BUT:
Bring back SYMFONY_TMP_DIR (in another form) for Docker optimization ezsystems/ezplatform#543
Let me know