[FrameworkBundle] Move console configuration to PHP #37216
Conversation
AhmedRaafat14
commented
Jun 11, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | #37186 |
| License | MIT |
| Doc PR | n/a |
1a68ab3 to
dd8b2cd
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php
Outdated
Show resolved
Hide resolved
fbfb026 to
1d88889
Compare
There was a problem hiding this comment.
@AhmedRaafat14 you were fast! This looks ready to merge. Thanks!
src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php
Outdated
Show resolved
Hide resolved
c680793 to
071c02a
Compare
| service('translation.extractor'), | ||
| param('translator.default_path'), | ||
| abstract_arg('twig.default_path'), | ||
| abstract_arg('Translator paths'), |
There was a problem hiding this comment.
<argument type="collection" />
Well, it seems we can't use abstract_arg() here, or we should add a new collection_abstract_arg() or something else to set [] as default.
The tests can be solved by setting [] for both collection arguments.
There was a problem hiding this comment.
@AhmedRaafat14 I afraid we need to change it again to [], // Translator paths, sorry, same for Twig paths argument (same for both commands), thanks!
There was a problem hiding this comment.
I was I did that it fixes the tests then I thought it might be me mistaken.
Thank you for confirming that I will update the PR ASAP.
There was a problem hiding this comment.
@javiereguiluz @yceruto
To fix the testing I had to revert back every collection argument to an empty array [] with a comment.
Also even for the console.command.translation_debug the unit tests failed with using abstract_arg('twig.default_path') it throws an exception that it expects string but got an AbstractArgument.
I will give it sometime tomorrow to try to fix it :) if I can. (in seperate PR for sure)
What do you think?
Exception Example:
Symfony\Component\DependencyInjection\Exception\InvalidParameterTypeException:
Invalid definition for service "console.command.translation_debug": argument 5 of
"Symfony\Bundle\FrameworkBundle\Command\TranslationDebugCommand::__construct"
accepts "string", "Symfony\Component\DependencyInjection\Argument\AbstractArgument" passed.
9b07f74 to
ef01839
Compare
|
Thank you @AhmedRaafat14. |
…lt is disabled (GromNaN)
This PR was merged into the 5.3 branch.
Discussion
----------
[Framework][Secrets] Fix service definition when local vault is disabled
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Local vault can be disabled with the following configuration:
```
framework:
secrets:
local_dotenv_file: ~
```
This removes the service `secrets.local_vault` ([code](https://github.com/symfony/symfony/blob/5.3/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L1669)). The `secrets:...` commands support this by having `$localVault` argument nullable.
When configuration was moved from XML to PHP in #37216, the attribute `on-invalid="ignore"` of some services was left.
Commits
-------
0e11f5a Fix commands when local vault is disabled