[3.4] Fix support for PHP8 union types #37340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66b074c to
f7e4b43
Compare
This was referenced Jun 18, 2020
9cd4a75 to
007e0ad
Compare
007e0ad to
e09372b
Compare
|
We need test cases for this, don't we? |
|
We might, PR welcome :) |
|
All right, on it. 🙈 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 18, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [4.4] Fix support for PHP8 union types | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #37340 for 4.4 Commits ------- da68e66 Fix support for PHP8 union types
nicolas-grekas
added a commit
that referenced
this pull request
Jun 18, 2020
This PR was merged into the 5.1 branch. Discussion ---------- [5.1] Fix support for PHP8 union types | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #37340 for 5.1 Commits ------- dd1b617 Fix support for PHP8 union types
|
see #37346 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 18, 2020
This PR was merged into the 3.4 branch. Discussion ---------- Added Unit tests for php 8 union types | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A The missing test cases for #37340. Commits ------- 2ca8ecd Added Unit tests for php 8 union types.
This was referenced Jul 24, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes fatal errors on PHP 8 once union types are used. Note that this doesn't provide support for union types, eg autowiring, serializer, etc will just skip them. If another behavior is desired, that'd be for the
5.xbranch.With PHP 8 coming, calling the
getName()on the object returned byReflectionParameter::getType()orReflectionFunctionAbstract::getReturnType()might fail. The reason is that these might return aReflectionUnionTypenow, which has nogetName()method (same for `isBuiltin() btw.)