Skip to content

Added Unit tests for php 8 union types #37346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Added Unit tests for php 8 union types #37346

merged 1 commit into from
Jun 18, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

The missing test cases for #37340.

@derrabus derrabus requested a review from dunglas as a code owner June 18, 2020 20:20
@derrabus derrabus mentioned this pull request Jun 18, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 18, 2020
@derrabus derrabus force-pushed the bugfix/3.4-union-types branch from 657b013 to 2ca8ecd Compare June 18, 2020 20:30
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit e707967 into symfony:3.4 Jun 18, 2020
@derrabus derrabus deleted the bugfix/3.4-union-types branch June 18, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot