[Mailer] Implement additional mailer transport options #37432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2020
fabpot
reviewed
Aug 13, 2020
9efb0e4 to
0db6030
Compare
|
|
Hm, what do you mean by that? It i used in the example. It is missing from the proposed documentation, that is true. |
fabpot
approved these changes
Aug 27, 2020
0db6030 to
665d1cd
Compare
|
Thank you @fritzmg. |
Merged
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Jan 7, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #2164 | Docs PR or issue | - This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes: * This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`. * Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`. * Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command). It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one. Commits ------- 5ea20a7 support native transport 53836ae use class_exists 3bbd552 update ContaoCoreBundleTest b084330 check for native mailer support in PluginTest too 4df690a update AddNativeTransportFactoryPassTest for prefer-lowest 72e72d2 Apply suggestions from code review Co-authored-by: Leo Feyer <github@contao.org> ad36b75 merge with master e98b617 removed superfluous function 1969b8e fix merge error 9fbdaf8 CS 49187f0 Merge branch 'master' into use-native-mailer
leofeyer
pushed a commit
to contao/manager-bundle
that referenced
this pull request
Jan 7, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #2164 | Docs PR or issue | - This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes: * This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`. * Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`. * Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command). It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one. Commits ------- 5ea20a71 support native transport 53836ae6 use class_exists 3bbd552f update ContaoCoreBundleTest b084330c check for native mailer support in PluginTest too 4df690a8 update AddNativeTransportFactoryPassTest for prefer-lowest 72e72d27 Apply suggestions from code review Co-authored-by: Leo Feyer <github@contao.org> ad36b75c merge with master e98b617f removed superfluous function 1969b8e1 fix merge error 9fbdaf8e CS 49187f05 Merge branch 'master' into use-native-mailer
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Jan 7, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #2164 | Docs PR or issue | - This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes: * This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`. * Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`. * Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command). It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one. Commits ------- 5ea20a71 support native transport 53836ae6 use class_exists 3bbd552f update ContaoCoreBundleTest b084330c check for native mailer support in PluginTest too 4df690a8 update AddNativeTransportFactoryPassTest for prefer-lowest 72e72d27 Apply suggestions from code review Co-authored-by: Leo Feyer <github@contao.org> ad36b75c merge with master e98b617f removed superfluous function 1969b8e1 fix merge error 9fbdaf8e CS 49187f05 Merge branch 'master' into use-native-mailer
AlexejKossmann
pushed a commit
to AlexejKossmann/contao
that referenced
this pull request
Apr 6, 2021
…ao#2554) Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes contao#2164 | Docs PR or issue | - This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes: * This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`. * Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`. * Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command). It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one. Commits ------- 5ea20a7 support native transport 53836ae use class_exists 3bbd552 update ContaoCoreBundleTest b084330 check for native mailer support in PluginTest too 4df690a update AddNativeTransportFactoryPassTest for prefer-lowest 72e72d2 Apply suggestions from code review Co-authored-by: Leo Feyer <github@contao.org> ad36b75 merge with master e98b617 removed superfluous function 1969b8e fix merge error 9fbdaf8 CS 49187f0 Merge branch 'master' into use-native-mailer
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 30, 2021
This PR was squashed before being merged into the 5.2 branch. Discussion ---------- [Mailer] Document new Mailer transport options This documents the additional options for the Mailer component introduced in symfony/symfony#37432 Commits ------- f713212 [Mailer] Document new Mailer transport options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements additional transport configuration options mentioned in #37300. It also adds a
commandoption to be able to define the command used by thesendmailtransport.Examples: