Fix redis connect with empty password #37791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Aug 10, 2020
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
9a8b439 to
e8bcf5f
Compare
ro0NL
reviewed
Aug 10, 2020
src/Symfony/Component/Messenger/Tests/Transport/RedisExt/ConnectionTest.php
Show resolved
Hide resolved
1b4014f to
f7648c0
Compare
fabpot
approved these changes
Aug 10, 2020
f7648c0 to
9946f7f
Compare
|
Thank you @alexander-schranz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use DSN like this it will fail as auth is called with an empty password:
The auth should only be called when a password is set to a specific string.
Else it will fail with:
Redis Conf "redis-nopass.conf":
requirepass ""