Skip to content

Fix redis connect with empty password #37791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix redis connect with empty password #37791

merged 1 commit into from
Aug 10, 2020

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Aug 10, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix -
License MIT
Doc PR symfony/symfony-docs#...

If you use DSN like this it will fail as auth is called with an empty password:

redis://%env(resolve:REDIS_PASSWORD)%@%env(resolve:REDIS_HOST)%

The auth should only be called when a password is set to a specific string.

Else it will fail with:

ERR Client sent AUTH, but no password is set

Redis Conf "redis-nopass.conf":

requirepass ""

chalasr
chalasr approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With minor comment

@alexander-schranz alexander-schranz changed the title Avoid redis auth call for empty password Fix redis connect with empty password Aug 10, 2020
fabpot
fabpot requested changes Aug 10, 2020
View reviewed changes
@alexander-schranz alexander-schranz force-pushed the bugfix/redis-empty-password branch 3 times, most recently from 9a8b439 to e8bcf5f Compare August 10, 2020 12:52
@alexander-schranz alexander-schranz force-pushed the bugfix/redis-empty-password branch from 1b4014f to f7648c0 Compare August 10, 2020 13:22
@fabpot fabpot force-pushed the bugfix/redis-empty-password branch from f7648c0 to 9946f7f Compare August 10, 2020 13:30
@fabpot
Copy link
Member

fabpot commented Aug 10, 2020

Thank you @alexander-schranz.

@fabpot fabpot merged commit b2e99e2 into symfony:4.4 Aug 10, 2020
@alexander-schranz alexander-schranz deleted the bugfix/redis-empty-password branch August 10, 2020 13:41
This was referenced Aug 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

+1 more reviewer

@ro0NL ro0NL ro0NL left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-schranz @fabpot @ro0NL @chalasr @carsonbot