Skip to content

[Workflow] Improve and fix #37822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2020
Merged

[Workflow] Improve and fix #37822

merged 1 commit into from
Aug 13, 2020

Conversation

noniagriconomie
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37815 review
License MIT
Doc PR #

Hi @lyrixx
thx for such fast PR take over :)

while reviewing i found this typo i think
also i reordered the constants inside the events class to map with the order of fireing event

lyrixx
lyrixx approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabpot
Copy link
Member

fabpot commented Aug 13, 2020

Thank you @noniagriconomie.

@fabpot fabpot merged commit 3867fb2 into symfony:master Aug 13, 2020
@noniagriconomie noniagriconomie deleted the feature-workflow-improve branch August 13, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noniagriconomie @fabpot @lyrixx @carsonbot