Skip to content

[Notifier] Add Sendinblue notifier. #38298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2020
Merged

[Notifier] Add Sendinblue notifier. #38298

merged 1 commit into from
Sep 27, 2020

Conversation

ptondereau
Copy link
Contributor

@ptondereau ptondereau commented Sep 24, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets no
License MIT
Doc PR todo

Add Sendinblue SMS notifier bridge.

@ptondereau ptondereau force-pushed the sendinblue-notifier branch 5 times, most recently from e9c47a4 to 968cebb Compare September 24, 2020 20:18
@ptondereau ptondereau marked this pull request as draft September 24, 2020 20:46
@ptondereau ptondereau force-pushed the sendinblue-notifier branch 5 times, most recently from 7459295 to 6def951 Compare September 25, 2020 07:30
@ptondereau ptondereau marked this pull request as ready for review September 25, 2020 07:40
@ptondereau ptondereau requested a review from fabpot September 26, 2020 07:59
@fabpot
Copy link
Member

fabpot commented Sep 27, 2020

Thank you @ptondereau.

@fabpot fabpot mentioned this pull request Sep 27, 2020
Closed
@fabpot fabpot merged commit 934b125 into symfony:master Sep 27, 2020
@jwzk
Copy link

jwzk commented Sep 27, 2020

I see that the type/tag/webUrl fields are missing in the POST request, which can be problematic if you need it and want to use the notifier.

@ptondereau
Copy link
Contributor Author

ptondereau commented Sep 27, 2020 •
edited
Loading

I see that the type/tag/webUrl fields are missing in the POST request, which can be problematic if you need it and want to use the notifier.

I have only added the required fields to work and for merge it as soon as possible. I’ll do another PR later if I have time

@ptondereau ptondereau deleted the sendinblue-notifier branch September 27, 2020 15:54
@drixs6o9 drixs6o9 mentioned this pull request Sep 28, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@drixs6o9 drixs6o9 drixs6o9 left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ptondereau @fabpot @jwzk @noniagriconomie @drixs6o9 @carsonbot