Skip to content

[Notifier] Sendinblue bridge missing parameters #38326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

drixs6o9
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
License MIT

As mentioned, this PR has missing parameters for Sendinblue. I added them :)

@fabpot
Copy link
Member

fabpot commented Sep 28, 2020

Can you tell us what these settings are for?

@drixs6o9
Copy link
Contributor Author

Can you tell us what these settings are for?

According to the Sendinblue documentation :
type - Type of the SMS. Marketing SMS messages are those sent typically with marketing content. Transactional SMS messages are sent to individuals and are triggered in response to some action, such as a sign-up, purchase, etc.
tag - Tag of the message
webUrl - Webhook to call for each event triggered by the message (delivered etc.)

@fabpot
Copy link
Member

fabpot commented Sep 28, 2020

So, I'm closing this PR as we don't want to support those options specifically for one provider. If we want one of them to be supported, it should be done globally. For the type, it should always be configured to "transactional" as this is how we use SMSes in notifier. For tag, we already have a generic support for them. Finally, webURL is not something supported for now.

@fabpot fabpot closed this Sep 28, 2020
@drixs6o9
Copy link
Contributor Author

So, I'm closing this PR as we don't want to support those options specifically for one provider. If we want one of them to be supported, it should be done globally. For the type, it should always be configured to "transactional" as this is how we use SMSes in notifier. For tag, we already have a generic support for them. Finally, webURL is not something supported for now.

Ok, no problem.
I didn't know that each providers should be had same minimal integration.

@drixs6o9 drixs6o9 deleted the sendinblue-notifier branch September 28, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants