Skip to content

[Form] Add "choice_translation_parameters" option #38469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

[Form] Add "choice_translation_parameters" option #38469

merged 1 commit into from
Dec 10, 2020

Conversation

VincentLanglet
Copy link
Contributor

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #36845
License MIT
Doc PR symfony/symfony-docs#13677

Original PR: #36851

@VincentLanglet VincentLanglet requested a review from xabbuh as a code owner October 7, 2020 17:01
@VincentLanglet VincentLanglet mentioned this pull request Oct 7, 2020
Closed
@nicolas-grekas nicolas-grekas changed the title Choice translation parameters [Form] Add "choice_translation_parameters" option Oct 12, 2020
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Oct 12, 2020
@VincentLanglet
Copy link
Contributor Author

As explained here: #36851 (comment)

I don't know how to avoid the deprecation in the tests (that's why they are failing).
That's the last thing before being RTM.

Could you help me @fabpot @xabbuh @nicolas-grekas ? Thanks.

@VincentLanglet
Copy link
Contributor Author

@fabpot @xabbuh @nicolas-grekas This PR is ready to merge except the deprecation in the tests.
But I don't know how to get rid of it... Could you give me some help ?

@VincentLanglet VincentLanglet force-pushed the choice_translation_parameters branch from 1564411 to 4606b5f Compare December 6, 2020 22:50
@VincentLanglet
Copy link
Contributor Author

I rebased, it should be RTM

@VincentLanglet VincentLanglet mentioned this pull request Dec 7, 2020
Closed
nicolas-grekas
nicolas-grekas reviewed Dec 8, 2020
View reviewed changes
yceruto
yceruto approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabpot fabpot force-pushed the choice_translation_parameters branch from 50dcd1c to 1ce5b03 Compare December 10, 2020 07:13
@fabpot
Copy link
Member

fabpot commented Dec 10, 2020

Thank you @VincentLanglet.

@fabpot fabpot merged commit 9b64be8 into symfony:5.x Dec 10, 2020
@VincentLanglet VincentLanglet mentioned this pull request Dec 13, 2020
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Jan 21, 2021
@OskarStark
minor #14699 [Form] Add choice_translation_parameters option (Vincent…
3fdfa01 
…Langlet)

This PR was merged into the 5.3-dev branch.

Discussion
----------

[Form] Add choice_translation_parameters option

Cherry pick of #13677

The feature is merged symfony/symfony#38469

Commits
-------

0470b00 Add choice_translation_parameters option
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@Tobion Tobion mentioned this pull request Jul 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

ChoiceType Field should have a choice_translation_parameters option.
5 participants
@VincentLanglet @fabpot @nicolas-grekas @yceruto @carsonbot