-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
CI for macOS #38620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI for macOS #38620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3af6d8d
to
5e67a57
Compare
5e67a57
to
2b506b4
Compare
This was referenced Nov 1, 2020
Closed
150488b
to
2caee43
Compare
2caee43
to
f553496
Compare
f553496
to
2fbe553
Compare
2fbe553
to
86506cf
Compare
88805ac
to
427a46a
Compare
427a46a
to
a2b8aff
Compare
a2b8aff
to
b00f9a3
Compare
Shall we close? |
b00f9a3
to
fee419e
Compare
Let's see if the issues have been resolved in the meantime. |
92a058d
to
408433a
Compare
0f1ba27
to
d39c07e
Compare
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 29, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [CI] Remove macOS jobs | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #38620 | License | MIT | Doc PR | - The CI on macOS is super transient. When we enabled it, it didn't allow spotting any issues. Which means that to me it doesn't cover anything we should care about. Commits ------- 39064fe [CI] Remove macOS jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Actions workflow that executes our test suite on macOS Catalina. Some tests are red here. I'm opening this PR as draft, so we can have a look at the failing tests and investigate.
The current setup runs the test suite on php 7.4. We could technically add a matrix setup for different php versions, but I don't expect new insights from that. Compatibility with older php releases is covered by our Travis jobs.
For me, macOS is mainly a developer OS and I expect those machines to be rather up to date. Both, php and macOS do yearly releases around the same time. It might be a good idea to generally follow them after ca. three months. This PR starts with php 8.0 on Catalina. We can switch to Big Sur as soon as GitHub provides a stable environment for it.