Skip to content

CI for macOS #38620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021
Merged

CI for macOS #38620

merged 1 commit into from
Dec 11, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Oct 18, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38586
License MIT
Doc PR N/A

This PR adds a GitHub Actions workflow that executes our test suite on macOS Catalina. Some tests are red here. I'm opening this PR as draft, so we can have a look at the failing tests and investigate.

The current setup runs the test suite on php 7.4. We could technically add a matrix setup for different php versions, but I don't expect new insights from that. Compatibility with older php releases is covered by our Travis jobs.

For me, macOS is mainly a developer OS and I expect those machines to be rather up to date. Both, php and macOS do yearly releases around the same time. It might be a good idea to generally follow them after ca. three months. This PR starts with php 8.0 on Catalina. We can switch to Big Sur as soon as GitHub provides a stable environment for it.

@derrabus derrabus added this to the 4.4 milestone Oct 18, 2020
@derrabus derrabus force-pushed the improvement/macos-ci branch 5 times, most recently from 3af6d8d to 5e67a57 Compare November 1, 2020 01:13
@derrabus derrabus force-pushed the improvement/macos-ci branch from 5e67a57 to 2b506b4 Compare November 1, 2020 17:14
@derrabus derrabus force-pushed the improvement/macos-ci branch 7 times, most recently from 150488b to 2caee43 Compare November 7, 2020 15:06
@derrabus derrabus force-pushed the improvement/macos-ci branch from 2caee43 to f553496 Compare November 12, 2020 23:16
@derrabus derrabus force-pushed the improvement/macos-ci branch from f553496 to 2fbe553 Compare November 21, 2020 00:38
@derrabus derrabus force-pushed the improvement/macos-ci branch from 2fbe553 to 86506cf Compare December 28, 2020 00:04
@derrabus derrabus force-pushed the improvement/macos-ci branch 3 times, most recently from 88805ac to 427a46a Compare March 1, 2021 01:19
@derrabus derrabus force-pushed the improvement/macos-ci branch from 427a46a to a2b8aff Compare April 2, 2021 15:39
@derrabus derrabus force-pushed the improvement/macos-ci branch from a2b8aff to b00f9a3 Compare June 27, 2021 21:06
@nicolas-grekas
Copy link
Member

Shall we close?

@derrabus derrabus force-pushed the improvement/macos-ci branch from b00f9a3 to fee419e Compare September 11, 2021 14:27
@derrabus
Copy link
Member Author

Let's see if the issues have been resolved in the meantime.

@derrabus derrabus force-pushed the improvement/macos-ci branch 8 times, most recently from 92a058d to 408433a Compare December 11, 2021 14:58
@derrabus derrabus marked this pull request as ready for review December 11, 2021 15:11
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 9603e56 into symfony:4.4 Dec 11, 2021
@derrabus derrabus deleted the improvement/macos-ci branch December 11, 2021 15:22
nicolas-grekas added a commit that referenced this pull request Dec 29, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

[CI] Remove macOS jobs

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38620
| License       | MIT
| Doc PR        | -

The CI on macOS is super transient.
When we enabled it, it didn't allow spotting any issues.
Which means that to me it doesn't cover anything we should care about.

Commits
-------

39064fe [CI] Remove macOS jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants