[Messenger] Fix mssql compatibility for doctrine transport. #39166
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
This PR looks like it fixes the problem. Can you try to cover your changes with a test? |
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
@derrabus I'm afraid this may be a bit beyond my capability. |
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
That's okay, I'll see if I can come up with a test. |
Add logic for locking row for update when the doctrine dbal connection is sqlsrv. This is a quick and dirty solution, but it prevents the need to rewrite the logic due to doctrine dbal limitations. See issue symfony#39117
293b237 to
37be094
Compare
|
Thank you @thsmrtone1. |
|
I've added a test in #39214. |
This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Test generated SQL | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up to #39166. This is an attempt to the SQL generated by the `Symfony\Component\Messenger\Transport\Doctrine\Connection::get()` method. The challange was to create a locking SELECT statement, taking into account the different ways to create a lock in different SQL dialects. This test verifies if the correct lock statements are generated for MySQL and SQL Server. Commits ------- 1f1b62a [Messenger] Test generated SQL
Add logic for locking row for update when the doctrine dbal connection is sqlsrv. This is a quick and dirty solution, but it prevents the need to rewrite the logic due to doctrine dbal limitations.
See issue #39117