[Notifier] [DX] UnsupportedMessageTypeException for notifier transports #39365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07c4b6c to
38157fc
Compare
fabpot
approved these changes
Dec 8, 2020
|
Can you check the failed tests? |
38157fc to
774f6f8
Compare
Yes will do 👍
I thought that, thanks! Any preference for the signature and shall we use |
6809c42 to
312920d
Compare
|
Tests fixed, the lat one is unrelated ❗ fabbot.io failure seems unrelated, and if you want can be fixed in a separate PR: diff -ru src/Symfony/Component/Notifier/Bridge/RocketChat/RocketChatTransport.php src/Symfony/Component/Notifier/Bridge/RocketChat/RocketChatTransport.php
--- src/Symfony/Component/Notifier/Bridge/RocketChat/RocketChatTransport.php 2020-12-08 11:06:07.893047631 +0000
+++ src/Symfony/Component/Notifier/Bridge/RocketChat/RocketChatTransport.php 2020-12-08 11:06:09.624988949 +0000
@@ -77,12 +77,12 @@
);
if (200 !== $response->getStatusCode()) {
- throw new TransportException(sprintf('Unable to post the RocketChat message: %s.', $response->getContent(false)), $response);
+ throw new TransportException(sprintf('Unable to post the RocketChat message: "%s".', $response->getContent(false)), $response);
}
$result = $response->toArray(false);
if (!$result['success']) {
- throw new TransportException(sprintf('Unable to post the RocketChat message: %s.', $result['error']), $response);
+ throw new TransportException(sprintf('Unable to post the RocketChat message: "%s".', $result['error']), $response);
}
}
}
diff -ru src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php
--- src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php 2020-12-08 11:06:08.584024219 +0000
+++ src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php 2020-12-08 11:06:09.624988949 +0000
@@ -78,7 +78,7 @@
if (200 !== $response->getStatusCode()) {
$result = $response->toArray(false);
- throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code %s).', $result['error_code']), $response);
+ throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code "%s").', $result['error_code']), $response);
}
}
} |
312920d to
fa39cd6
Compare
jderusse
reviewed
Dec 9, 2020
7cab59b to
70c3093
Compare
ogizanagi
approved these changes
Dec 11, 2020
ogizanagi
suggested changes
Dec 11, 2020
src/Symfony/Component/Notifier/Transport/TransportInterface.php
Outdated
Show resolved
Hide resolved
OskarStark
commented
Dec 11, 2020
src/Symfony/Component/Notifier/Transport/TransportInterface.php
Outdated
Show resolved
Hide resolved
ogizanagi
approved these changes
Dec 11, 2020
jderusse
approved these changes
Dec 11, 2020
f40a051 to
cf1d352
Compare
|
Thank you @OskarStark. |
This was referenced Dec 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to streamline the experience, creating new notifier transports. Maybe such exceptions fit well, as we are planing to get more and more transports and don't want to "pollute" the transports itself with repeatable code.
Please let me know if you are open to have such exceptions as I would like to introduce more of them for unsupported options for example and if this should be considered a new feature or it should be applied against
5.1?I am not sure about the signature and the name of the new
UnsupportedMessageTypeException.Cheers