Skip to content

Fix enabled key for ratelimiter config #39442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix enabled key for ratelimiter config #39442

merged 1 commit into from
Dec 11, 2020

Conversation

pierredup
Copy link
Contributor

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

The enabled key doesn't always exist in the config when using the ratelimiter component, which causes an undefined index error

@pierredup pierredup mentioned this pull request Dec 11, 2020
Closed
@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Dec 11, 2020
@nicolas-grekas nicolas-grekas changed the base branch from 5.x to 5.2 December 11, 2020 10:00
wouterj
wouterj approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is perfect imho :)

@jderusse
Copy link
Member

Thank you @pierredup.

@jderusse jderusse merged commit cb05fab into symfony:5.2 Dec 11, 2020
@fabpot fabpot mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@jderusse jderusse jderusse approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@pierredup @jderusse @stof @wouterj @nicolas-grekas @carsonbot