[RateLimiter] add enabled param to rate_limiter config #14655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hosseinsalemi! If I'm correct, you should not need this option as it's enabled whenever you're configuring on of the rate limiters below it. Did you have any other experience with this? |
|
@wouterj I think the issue here is, without that config, you get an There is a PR at symfony/symfony#39442 to fix this behaviour to catch cases when |
|
Alright, as the fix on symfony/symfony will be merged, I'm going to close the PR here (this addition becomes redundant after 5.2.1, which will probably be released in at most 2 weeks time). Thank you @pierredup for providing all these fixes to the rate limiter docs & code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.