[PhpUnitBridge] Restore SetUpTearDownTraitForV5 #39487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ed5fab to
65bea85
Compare
derrabus
approved these changes
Dec 13, 2020
|
On PHP 7.1, you can simply define |
|
Deprecating added |
nicolas-grekas
approved these changes
Dec 14, 2020
73f7929 to
e2198a8
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 14, 2020
…derusse) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] [phpunit] Stop using deprecated trait | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - the `SetUpTearDownTrait` trait has been removed in #39487 this PR remove usage of it in branch 4.4 Commits ------- 55ed00c Stop using deprecated trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
SetUpTearDownTraitForV5removed in #39419 is still needed when using PHPUNIT 7.5 (PHP 7.1) that does not have return type:https://github.com/sebastianbergmann/phpunit/blob/520723129e2b3fc1dc4c0953e43c9d40e1ecb352/src/Framework/TestCase.php#L407