[Notifier] [DX] Abstract test cases #39495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59dc394 to
2996190
Compare
fabpot
added a commit
that referenced
this pull request
Dec 15, 2020
… (OskarStark) This PR was merged into the 5.1 branch. Discussion ---------- [Notifier] [Free Mobile] Could not use custom host in DSN | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- While working on #39509 I discovered, that you cannot set a custom host through the DSN string itself, only by calling `setHost()` method in the transport, which is only possible by **not** using the factory.... I changed it the way all other bridges work. I don't add a testcase for the port, because non of the others have that test. I plan to implement it in #39495 As this is a bugfix I created an extra PR. Cheers EDIT: Also the host is not allowed to contain `https://` otherwise calling `__toString()` will result in: `freemobile://https://......` Commits ------- 63350cc [Notifier] [Free Mobile] Could not use custom host in DSN
9db839b to
30f9436
Compare
jderusse
reviewed
Dec 16, 2020
src/Symfony/Component/Notifier/Bridge/Nexmo/Tests/NexmoTransportTest.php
Show resolved
Hide resolved
a030df5 to
8d7700f
Compare
OskarStark
commented
Dec 20, 2020
| @@ -18,7 +18,7 @@ | |||
| "require": { | |||
| "php": ">=7.2.5", | |||
| "symfony/http-client": "^4.3|^5.0", | |||
| "symfony/notifier": "~5.1.0" | |||
| "symfony/notifier": "~5.1.10" | |||
There was a problem hiding this comment.
I guess I need to bump this to ~5.1.11, now that 5.1.10 was released, right?
8d60f8b to
c7d773a
Compare
|
Ready to merge from my side 👍 |
derrabus
requested changes
Dec 21, 2020
src/Symfony/Component/Notifier/Bridge/Firebase/Tests/FirebaseTransportFactoryTest.php
Show resolved
Hide resolved
derrabus
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Okay, first of all, I really like the new test case classes. They give the tests of all bridges more structure and makes it easier to maintain.
But:
- We're basically rewriting the test suites of all notifier bridges for the 5.1 branch here. That branch is going to die next month.
- I have merged several tests refactorings from 5.1 to 5.2 and had to solve quite a few conflicts each time. Slack bridge, I'm looking at you.
- Quite a few bridges have changed fundamentally in 5.2. It is close to impossible to merge this PR cleanly to 5.2 and beyond.
So, this PR certainly improves things, but I wonder if we should really target 5.1.
67a1a5b to
7614cdf
Compare
If you like you can just merge it in |
jderusse
approved these changes
Dec 22, 2020
7614cdf to
79379b7
Compare
|
Thank you Oskar. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 7, 2021
This PR was squashed before being merged into the 5.2 branch. Discussion ---------- [Notifier] Use abstract test cases in 5.2 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follows #39495 | License | MIT | Doc PR | --- Same as #39495, but for `5.2` cc @derrabus Commits ------- 8f6b08c [Notifier] Use abstract test cases in 5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
TransportTestCaseTransportFactoryTestCase(code is mainly taken from theMailer/TransportFactoryTestCase)We have a lot of code duplication in the notifier bridges
Todos
~5.1.10Questions
5.1?Abstract? As we did the same for Mailer, I would say no@symfony/mergers have to change ^5.2 into ^5.2.1