[Notifier] Improve tests (5.1) #39509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
711aa79 to
bd3513c
Compare
fabpot
added a commit
that referenced
this pull request
Dec 15, 2020
… (OskarStark) This PR was merged into the 5.1 branch. Discussion ---------- [Notifier] [Free Mobile] Could not use custom host in DSN | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- While working on #39509 I discovered, that you cannot set a custom host through the DSN string itself, only by calling `setHost()` method in the transport, which is only possible by **not** using the factory.... I changed it the way all other bridges work. I don't add a testcase for the port, because non of the others have that test. I plan to implement it in #39495 As this is a bugfix I created an extra PR. Cheers EDIT: Also the host is not allowed to contain `https://` otherwise calling `__toString()` will result in: `freemobile://https://......` Commits ------- 63350cc [Notifier] [Free Mobile] Could not use custom host in DSN
bd3513c to
9cabbcb
Compare
|
Ready to merge from my side, if tests pass 😄 Good night! 🌔 |
jderusse
approved these changes
Dec 15, 2020
derrabus
approved these changes
Dec 16, 2020
9cabbcb to
5773a46
Compare
|
Thank you Oskar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit