Skip to content

[Notifier] Add GatewayApi bridge #39568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

[Notifier] Add GatewayApi bridge #39568

merged 1 commit into from
Jan 14, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Dec 18, 2020 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Replaces #38685
License MIT
Doc PR symfony/symfony-docs#14463
Recipe PR symfony/recipes#864

Initial PR by @PGLongo

@OskarStark OskarStark closed this Dec 18, 2020
@OskarStark OskarStark reopened this Dec 18, 2020
@OskarStark OskarStark closed this Dec 18, 2020
@OskarStark OskarStark reopened this Dec 18, 2020
@OskarStark OskarStark changed the title 5.x rebased [Notifier] Add GatewayApi bridge Dec 18, 2020
@OskarStark OskarStark mentioned this pull request Dec 20, 2020
Merged
@OskarStark
Copy link
Contributor Author

I suppose test are green after #39571 🤔

cc @chalasr

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Dec 23, 2020
@OskarStark
Copy link
Contributor Author

Ready to merge

@OskarStark OskarStark force-pushed the 5.x-rebased branch 2 times, most recently from 1428384 to dccc8aa Compare January 6, 2021 15:58
@OskarStark OskarStark force-pushed the 5.x-rebased branch 2 times, most recently from c088dd3 to b228dbc Compare January 6, 2021 16:17
@OskarStark
Copy link
Contributor Author

Ready to merge 👍

@OskarStark OskarStark mentioned this pull request Jan 7, 2021
Merged
@derrabus
Copy link
Member

derrabus commented Jan 7, 2021

@OskarStark Can you have a look at the tests?

@OskarStark
Copy link
Contributor Author

OskarStark commented Jan 7, 2021 •
edited
Loading

Done @derrabus , lets see if its working now.

Btw, its weird that one passed... 🤔
CleanShot 2021-01-07 at 11 04 15

And fabbot.io is complaining:
CleanShot 2021-01-07 at 11 05 35

@OskarStark
Copy link
Contributor Author

Tests green 💚

@OskarStark
Copy link
Contributor Author

Travis failure unrelated

@OskarStark
Copy link
Contributor Author

Thank you Piergiuseppe Longo.

@OskarStark OskarStark merged commit e55762d into symfony:5.x Jan 14, 2021
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @derrabus @nicolas-grekas @carsonbot @PGLongo